crypto: fix CA trust block parsing - #64753
Merged
Merged
Conversation
Collaborator
|
Review requested:
|
nodejs-github-bot
added
c++
This comment was marked as spam.
This comment was marked as spam.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #64753 +/- ##
==========================================
- Coverage 90.28% 90.25% -0.03%
==========================================
Files 762 762
Lines 247520 247524 +4
Branches 46692 46688 -4
==========================================
- Hits 223468 223409 -59
- Misses 15483 15534 +51
- Partials 8569 8581 +12 🚀 New features to boost your workflow:
|
This comment was marked as spam.
This comment was marked as spam.
github-actions
Bot
removed
the
request-ci
Collaborator
This comment was marked as spam.
This comment was marked as spam.
jasnell
approved these changes
Aug 2, 2026
This comment was marked as spam.
This comment was marked as spam.
Renegade334
requested changes
Aug 3, 2026
Renegade334
left a comment
Renegade334
left a comment
Member
There was a problem hiding this comment.
This diverges from upstream and has the potential to be brittle. We should be re-synchronising this script with curl, as 5be9efc did (minus our own modifications).
Member
|
eg. 6c96168 |
This comment was marked as spam.
This comment was marked as spam.
Synchronize mk-ca-bundle.pl with curl 1.33. This brings in curl's corrected handling of NSS distrust-after metadata. Refs: https://github.com/curl/curl/blob/0ada20387c31c638cfd7f6b4ae7e5cab5b318caf/scripts/mk-ca-bundle.pl Signed-off-by: Archkon <180910180+Archkon@users.noreply.github.com>
Regenerate node_root_certs.h with the updated parser, restoring the Izenpe.com root certificate whose SERVER_AUTH trust attribute follows CKA_NSS_SERVER_DISTRUST_AFTER metadata. Co-authored-by: Renegade334 <contact.9a5d6388@renegade334.me.uk> Signed-off-by: Archkon <180910180+Archkon@users.noreply.github.com>
Renegade334
approved these changes
Aug 3, 2026
Renegade334
left a comment
Renegade334
left a comment
Member
There was a problem hiding this comment.
👍
Verified output with tools/mk-ca-bundle.pl -i and with a test run of the root-certs updater.
Renegade334
added
commit-queue-squash
github-actions
Bot
removed
the
request-ci
Collaborator
This comment was marked as spam.
This comment was marked as spam.
avivkeller
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
Collaborator
|
Landed in 579fb17 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #64752